Skip to content

feat: Create invitation links for join to team#4887

Open
Koc wants to merge 1 commit into
mainfrom
feature/create-invitation-links
Open

feat: Create invitation links for join to team#4887
Koc wants to merge 1 commit into
mainfrom
feature/create-invitation-links

Conversation

@Koc

@Koc Koc commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown

This PR adds possibility to generate invitation link (even for completely hidden/closed Circles). Any user is able to join to C circle by opening this link.

Preview

Invitation link management

image image

Invitation link opened

image

Invitation link opened when user already joined to a Circle

image

Invitation link opened when user already requested join to a Circle

image

Dependencies

@Koc Koc force-pushed the feature/create-invitation-links branch 5 times, most recently from 97bbf10 to d073a9b Compare November 29, 2025 22:59
@codecov

codecov Bot commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.35714% with 106 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/JoinInvitation.vue 0.00% 50 Missing ⚠️
...tails/CircleConfigs/CircleConfigCheckboxesList.vue 15.78% 16 Missing ⚠️
...tails/CircleConfigs/CircleConfigInvitationLink.vue 15.78% 16 Missing ⚠️
src/store/circles.js 0.00% 8 Missing ⚠️
lib/Controller/PageController.php 0.00% 5 Missing ⚠️
src/components/CircleDetails/CircleSettings.vue 0.00% 5 Missing ⚠️
src/join-invitation.js 0.00% 5 Missing ⚠️
appinfo/routes.php 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Koc Koc force-pushed the feature/create-invitation-links branch 5 times, most recently from e887136 to 73eab05 Compare November 30, 2025 22:19
Koc
Koc commented Dec 1, 2025
View reviewed changes
Comment thread templates/message.php Outdated
@Koc Koc force-pushed the feature/create-invitation-links branch 3 times, most recently from f7d5f60 to 04cef57 Compare December 7, 2025 13:20
@Koc Koc marked this pull request as ready for review December 7, 2025 13:26
@Koc Koc mentioned this pull request Dec 7, 2025
Open
Koc
Koc commented Dec 7, 2025
View reviewed changes
Comment thread src/components/JoinInvitation.vue Outdated
GVodyanov
GVodyanov reviewed Dec 7, 2025
View reviewed changes
Comment thread src/models/constants.ts
@GVodyanov

GVodyanov commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

This is looking like a cool PR! I really like this feature, and the code (at least the front-end which I'm responsible for), is looking good.

However, I am having an issue where I am not able to load my previously created teams when checking out your PR in circles, is this something others are also experiencing?

@GVodyanov

GVodyanov commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

@nfebe Hey! What do you think of this? You maintain the frontend for circles right?

@Koc Koc force-pushed the feature/create-invitation-links branch 2 times, most recently from d114d0d to 7f90869 Compare April 16, 2026 23:35
@Koc

Koc commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@GVodyanov

However, I am having an issue where I am not able to load my previously created teams when checking out your PR in circles, is this something others are also experiencing?

I haven't anything like that. What error do you have? Please provide more detals, e.g. logs, screenshoots, etc

Rebased PR, BTW.

@Koc Koc force-pushed the feature/create-invitation-links branch from 7f90869 to e528e56 Compare June 28, 2026 10:57
@Koc Koc requested a review from mejo- June 28, 2026 11:08
@Koc Koc force-pushed the feature/create-invitation-links branch from e528e56 to 8d5b136 Compare June 28, 2026 12:30
@Koc Koc force-pushed the feature/create-invitation-links branch 3 times, most recently from 92933ce to 0f564c2 Compare June 28, 2026 13:05
@Koc
feat: Create invitation links
3bf637a 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc Koc force-pushed the feature/create-invitation-links branch from 0f564c2 to 3bf637a Compare June 28, 2026 13:25
@hamza221 hamza221 added 3. to review Waiting for reviews feature: teams ex circles labels Jul 7, 2026
@ChristophWurst ChristophWurst requested review from ArtificialOwl and cristianscheid and removed request for SebastianKrupinski and hamza221 July 7, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GVodyanov GVodyanov GVodyanov left review comments
@mejo- mejo- Awaiting requested review from mejo-
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl
@cristianscheid cristianscheid Awaiting requested review from cristianscheid

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: teams ex circles

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koc @GVodyanov @hamza221